Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip #976

Closed
rachael-phillips opened this issue Nov 28, 2018 · 7 comments · Fixed by #1180
Closed

Chip #976

rachael-phillips opened this issue Nov 28, 2018 · 7 comments · Fixed by #1180
Assignees
Milestone

Comments

@rachael-phillips
Copy link
Contributor

rachael-phillips commented Nov 28, 2018

Related Core Issue: patternfly/patternfly#177

In addition to a React review, this issue should be reviewed by the core contributors:
CSS: @christiemolloy and @mcarrano

React Interaction:

  • Close button should remove chip.
  • Overflow button should show and hide chips
  • Overflow button should count how many chips have overflown
@rachael-phillips rachael-phillips added this to the 1.0.0-alpha.6 milestone Nov 28, 2018
@ibolton336 ibolton336 self-assigned this Dec 3, 2018
@tconn89
Copy link

tconn89 commented Dec 3, 2018

I do not see a Chip component in the code. Are you referring to a Badge?

If not are you referring to a tag? If so, would this issue be dependent on PR #351 Introduce Tagging React component?

@LHinson LHinson changed the title Filter Chip Chip Dec 5, 2018
@LHinson
Copy link
Member

LHinson commented Dec 5, 2018

@ibolton336 will you be providing the api review/recommendations only are do you also plan to implement the component?

@ibolton336
Copy link
Member

@LHinson Ah I thought this issue only involved the API review recommendations.

@LHinson
Copy link
Member

LHinson commented Dec 5, 2018

@ibolton336 the issue covers both. the standard initial API review/recommendations and then moves on to component implementation. I just wasn't sure if you were assigned to complete one or both.

@ibolton336
Copy link
Member

@LHinson @rachael-phillips I can take a crack at implementing the react component for this.

@rachael-phillips
Copy link
Contributor Author

Ok great! Thank you @ibolton336 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants