-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chip #976
Comments
I do not see a Chip component in the code. Are you referring to a Badge? If not are you referring to a tag? If so, would this issue be dependent on PR #351 Introduce Tagging React component? |
@ibolton336 will you be providing the api review/recommendations only are do you also plan to implement the component? |
@LHinson Ah I thought this issue only involved the API review recommendations. |
@ibolton336 the issue covers both. the standard initial API review/recommendations and then moves on to component implementation. I just wasn't sure if you were assigned to complete one or both. |
@LHinson @rachael-phillips I can take a crack at implementing the react component for this. |
Ok great! Thank you @ibolton336 ! |
Related Core Issue: patternfly/patternfly#177
In addition to a React review, this issue should be reviewed by the core contributors:
CSS: @christiemolloy and @mcarrano
React Interaction:
The text was updated successfully, but these errors were encountered: