Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Less -> Sass Converter #169

Closed
jeff-phillips-18 opened this issue Jan 17, 2018 · 3 comments
Closed

Add Less -> Sass Converter #169

jeff-phillips-18 opened this issue Jan 17, 2018 · 3 comments
Assignees
Labels

Comments

@jeff-phillips-18
Copy link
Member

Since we need to support both Less and Sass, we should use a converted to that contributors need only create the less files rather than both.

See patternfly/angular-patternfly#692

@cdcabrera
Copy link
Member

cdcabrera commented Apr 19, 2018

This is minor, but if anyone is curious. @jeff-phillips-18 @priley86 Looks like a side piece to this issue/task could be addressing some of the Sass NPM install issues vs the Yarn install.

The optional dependency install "bootstrap-sass": "^3.3.7" from Patternfly core is where it's at... adding bootstrap-sass into PF-React as some form of dependency resolves NPMs issues.

Yarn just solves it =)

@stale
Copy link

stale bot commented Jun 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jun 6, 2019
@jeff-phillips-18
Copy link
Member Author

Given the status of pf3 react and the difficulty of this request, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants