Skip to content

Commit

Permalink
Updates to kotlin 1.6; compile target remains 1.4 (#1117)
Browse files Browse the repository at this point in the history
  • Loading branch information
rchowell authored Jun 8, 2023
1 parent e0eea80 commit 22bbf70
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 7 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Updates Kotlin from 1.5.+ to 1.6; compile target remains 1.4
- Moves PartiqlAst, PartiqlLogical, PartiqlLogicalResolved, and PartiqlPhysical (along with the transforms)
to a new project, `partiql-ast`. These are still imported into `partiql-lang` with the `api` annotation. Therefore,
no action is required to consume the migrated classes. However, this now gives consumers of the AST, Experimental Plans,
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ repositories {
object Versions {
const val detekt = "1.20.0-RC1"
const val dokka = "1.6.10"
const val kotlin = "1.5.+"
const val kotlin = "1.6.20"
const val ktlint = "10.2.1"
const val pig = "0.6.1"
}
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/kotlin/partiql.conventions.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ java {

tasks.test {
useJUnitPlatform() // Enable JUnit5
jvmArgs!!.addAll(listOf("-Duser.language=en", "-Duser.country=US"))
jvmArgs.addAll(listOf("-Duser.language=en", "-Duser.country=US"))
maxHeapSize = "4g"
testLogging {
events.add(TestLogEvent.FAILED)
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/kotlin/partiql.versions.kt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

object Versions {
// Language
const val kotlin = "1.5.31"
const val kotlin = "1.6.20"
const val kotlinTarget = "1.4"
const val javaTarget = "1.8"

Expand Down
3 changes: 1 addition & 2 deletions examples/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ dependencies {
implementation(Deps.awsSdkS3)
}

// TODO: Once we upgrade kotlin version to 1.6+, we need to change the compile option to -opt-in
// Version 1.7+ removes the requirement for such compiler option.
tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach {
kotlinOptions
.freeCompilerArgs += "-Xopt-in=kotlin.RequiresOptIn"
.freeCompilerArgs += "-opt-in=kotlin.RequiresOptIn"
}
3 changes: 1 addition & 2 deletions partiql-cli/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,8 @@ tasks.register<GradleBuild>("install") {
tasks = listOf("assembleDist", "distZip", "installDist")
}

// TODO: Once we upgrade kotlin version to 1.6+, we need to change the compile option to -opt-in
// Version 1.7+ removes the requirement for such compiler option.
tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach {
kotlinOptions
.freeCompilerArgs += "-Xopt-in=kotlin.RequiresOptIn"
.freeCompilerArgs += "-opt-in=kotlin.RequiresOptIn"
}

1 comment on commit 22bbf70

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JMH Benchmark

Benchmark suite Current: 22bbf70 Previous: e0eea80 Ratio
org.partiql.jmh.benchmarks.MultipleLikeBenchmark.testPartiQLCompiler15 180.59642284982587 us/op 145.3464086196161 us/op 1.24
org.partiql.jmh.benchmarks.MultipleLikeBenchmark.testPartiQLCompiler30 325.7449272551978 us/op 282.8004310959449 us/op 1.15
org.partiql.jmh.benchmarks.MultipleLikeBenchmark.testPartiQLEvaluator15 593851.5354250001 us/op 625054.084025 us/op 0.95
org.partiql.jmh.benchmarks.MultipleLikeBenchmark.testPartiQLEvaluator30 1109215.4025499998 us/op 1241796.5380499999 us/op 0.89
org.partiql.jmh.benchmarks.MultipleLikeBenchmark.testPartiQLEvaluator30WithData10 12015642.941949999 us/op 12289623.5002 us/op 0.98
org.partiql.jmh.benchmarks.MultipleLikeBenchmark.testPartiQLParser15 277.35165999393524 us/op 253.44868766389988 us/op 1.09
org.partiql.jmh.benchmarks.MultipleLikeBenchmark.testPartiQLParser30 518.8141462151699 us/op 466.5637775361104 us/op 1.11
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameCaseWhenThen 77.8027201961174 us/op 54.19973880667938 us/op 1.44
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameComplexQuery 95.52593042164739 us/op 75.6980203726054 us/op 1.26
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameComplexQuery01 453.2557837242613 us/op 400.7150388453174 us/op 1.13
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameComplexQuery02 791.2080321801193 us/op 694.8660434103784 us/op 1.14
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameExceptUnionIntersectSixty 319.4115763949329 us/op 256.4532614204535 us/op 1.25
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameExec20Expressions 96.2188404830405 us/op 78.89189537535243 us/op 1.22
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameFromLet 84.10505199420882 us/op 56.305410029926385 us/op 1.49
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameGraphPattern 79.92120492477297 us/op 56.913709896499014 us/op 1.40
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameGraphPreFilters 126.78505157400718 us/op 85.4060319999152 us/op 1.48
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameGroupLimit 104.50607235374866 us/op 69.53656046126167 us/op 1.50
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameLongFromSourceOrderBy 101.54772692627988 us/op 82.39778197354278 us/op 1.23
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameManyJoins 117.50323972667684 us/op 81.35589990698617 us/op 1.44
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameNestedAggregates 185.87433293677452 us/op 140.23196152108207 us/op 1.33
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameNestedParen 34.07550365745011 us/op 25.989963663892684 us/op 1.31
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNamePivot 118.23661447292325 us/op 87.89276598322294 us/op 1.35
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameQuery15OrsAndLikes 355.38119093351577 us/op 264.58804141577355 us/op 1.34
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameQuery30Plus 171.7755157517557 us/op 147.83018233596908 us/op 1.16
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameQueryFunc 79.93721076497052 us/op 59.73959749887852 us/op 1.34
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameQueryFuncInProjection 177.35490596728283 us/op 137.12670631316726 us/op 1.29
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameQueryList 131.87717611050394 us/op 101.01937839344518 us/op 1.31
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameQueryNestedSelect 986.0890138228784 us/op 948.573729861894 us/op 1.04
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameQuerySimple 31.88496229915839 us/op 23.844047019083394 us/op 1.34
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameSeveralJoins 42.90213463807168 us/op 31.674501074965445 us/op 1.35
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameSeveralProjections 119.66430943851734 us/op 94.62767773399365 us/op 1.26
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameSeveralSelect 339.2153017685914 us/op 249.0134416974945 us/op 1.36
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameSimpleInsert 56.6628188785415 us/op 40.254008001671174 us/op 1.41
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameSomeJoins 43.638931742536776 us/op 31.704441587346594 us/op 1.38
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameSomeProjections 58.09017753728109 us/op 40.8899998052229 us/op 1.42
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameSomeSelect 94.83101804375072 us/op 68.89413733605615 us/op 1.38
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameTimeZone 47.627711071317535 us/op 35.318530424599466 us/op 1.35
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameVeryLongQuery 488.78472290387225 us/op 423.04994939237884 us/op 1.16
org.partiql.jmh.benchmarks.ParserBenchmark.parseFailNameVeryLongQuery01 1610.8893712938695 us/op 1306.889697435348 us/op 1.23
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameCaseWhenThen 44.52292290558844 us/op 35.0094085997769 us/op 1.27
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameComplexQuery 433.87201715019893 us/op 324.06801953852425 us/op 1.34
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameComplexQuery01 181.21813486616796 us/op 154.7688332681288 us/op 1.17
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameExceptUnionIntersectSixty 345.933762507183 us/op 297.89204046642357 us/op 1.16
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameExec20Expressions 108.55132832073589 us/op 88.6100811793199 us/op 1.23
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameFromLet 66.63849561914743 us/op 49.54928351543659 us/op 1.34
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameGraphPattern 74.16012232303045 us/op 55.48187631999932 us/op 1.34
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameGraphPreFilters 115.01770229878518 us/op 94.66161788840796 us/op 1.22
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameGroupLimit 65.89799875744606 us/op 46.83550005063738 us/op 1.41
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameLongFromSourceOrderBy 230.49464231470006 us/op 174.76522503562933 us/op 1.32
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameManyJoins 74.59622024745286 us/op 58.48757368680659 us/op 1.28
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameNestedAggregates 157.62547429658613 us/op 128.74438030671453 us/op 1.22
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameNestedParen 115.47219906827713 us/op 105.23964196412199 us/op 1.10
org.partiql.jmh.benchmarks.ParserBenchmark.parseNamePivot 111.87348600473274 us/op 88.85794369370805 us/op 1.26
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameQuery15OrsAndLikes 263.06247139445816 us/op 241.20924586175812 us/op 1.09
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameQuery30Plus 85.94435469178924 us/op 80.85136876578933 us/op 1.06
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameQueryFunc 203.38006937895472 us/op 177.0144665559644 us/op 1.15
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameQueryFuncInProjection 146.7450733600933 us/op 123.20080804473011 us/op 1.19
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameQueryList 122.30164025324208 us/op 109.45962411808657 us/op 1.12
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameQueryNestedSelect 218.3817045781031 us/op 185.37153652112502 us/op 1.18
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameQuerySimple 23.256348443812094 us/op 17.738689221141886 us/op 1.31
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameSeveralJoins 116.51863531572056 us/op 102.32503247972694 us/op 1.14
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameSeveralProjections 85.7213116325797 us/op 76.08962290504903 us/op 1.13
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameSeveralSelect 168.91173419528684 us/op 149.6909559776231 us/op 1.13
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameSimpleInsert 38.541668762214606 us/op 30.563407077054997 us/op 1.26
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameSomeJoins 38.630789406792026 us/op 29.69996240621314 us/op 1.30
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameSomeProjections 32.38023650091448 us/op 26.88077289661208 us/op 1.20
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameSomeSelect 56.3925913879025 us/op 47.42754129039272 us/op 1.19
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameTimeZone 17.689791089543064 us/op 12.754583812812758 us/op 1.39
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameVeryLongQuery 659.1871258004817 us/op 601.770311735555 us/op 1.10
org.partiql.jmh.benchmarks.ParserBenchmark.parseNameVeryLongQuery01 1674.0934172157117 us/op 1638.3906794965944 us/op 1.02
org.partiql.jmh.benchmarks.PartiQLBenchmark.testPartiQLCompiler 14.728592754383595 us/op 12.700154585668887 us/op 1.16
org.partiql.jmh.benchmarks.PartiQLBenchmark.testPartiQLEvaluator 2.8577561531134448 us/op 2.783307925893188 us/op 1.03
org.partiql.jmh.benchmarks.PartiQLBenchmark.testPartiQLParser 21.6908671745038 us/op 16.72217177960014 us/op 1.30

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.