Skip to content
This repository was archived by the owner on May 21, 2024. It is now read-only.

Breaking change on pallet_asset_tx_payment for polkadot-v.0.28 release. #48

Closed
hbulgarini opened this issue Aug 24, 2022 · 1 comment · Fixed by #55
Closed

Breaking change on pallet_asset_tx_payment for polkadot-v.0.28 release. #48

hbulgarini opened this issue Aug 24, 2022 · 1 comment · Fixed by #55
Assignees
@bernardoaraujor

Comments

@hbulgarini
Copy link
Contributor

hbulgarini commented Aug 24, 2022 •
edited
Loading

This PR paritytech/substrate#11690 on cumulus paritytech/cumulus#1377) introduces a breaking change over the pallet_asset_tx_payment used in Trappist runtime. For the records, this change is adding events for the pallet so we should add the event associated type for the Config trait as it was done on Statemine.

When we bump our substrate version to polkadot-v0.9.28 we should update our runtime accordingly.
@bernardoaraujor bernardoaraujor self-assigned this Aug 31, 2022
@hbulgarini hbulgarini changed the title Breaking change on pallet_asset_tx_payment. Breaking change on pallet_asset_tx_payment for polkadot-v.0.28 release. Aug 31, 2022
@bernardoaraujor bernardoaraujor mentioned this issue Aug 31, 2022
Closed
@bernardoaraujor
Copy link
Contributor

bernardoaraujor commented Aug 31, 2022 •
edited
Loading

I have a working fix on https://github.com/bernardoaraujor/trappist/tree/48-pallet-asset-tx-payment-event

waiting for paritytech/substrate-dex#30 to be merged so that I can remove my substrate-dex fork from the dependencies and send a PR here

This was referenced Sep 1, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bernardoaraujor bernardoaraujor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bump polkadot-0.9.28] + [pallet-asset-tx-payment event] bernardoaraujor/trappist
2 participants
@bernardoaraujor @hbulgarini