Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Code that uses runtime interface should not be used outside runtime #5554

Closed
NikVolf opened this issue Apr 7, 2020 · 4 comments · Fixed by #6616
Closed

Code that uses runtime interface should not be used outside runtime #5554

NikVolf opened this issue Apr 7, 2020 · 4 comments · Fixed by #6616
Labels
I7-refactor Code needs refactoring.

Comments

@NikVolf
Copy link
Contributor

NikVolf commented Apr 7, 2020 •
edited
Loading

For example, Verify trait implementations for signatures calls runtime interface through sp_io::crypto::*, so using it outside of runtime is suboptimal and in most cases not needed.
@NikVolf NikVolf added the I7-refactor Code needs refactoring. label Apr 7, 2020
@bkchr
Copy link
Member

bkchr commented Apr 7, 2020

Verify trait is not the problem ;) The trait lives in sp-runtime and these are primitives for the runtime.

@NikVolf
Copy link
Contributor Author

NikVolf commented Apr 7, 2020

But the usage of this outside of runtime is a problem

@bkchr
Copy link
Member

bkchr commented Apr 7, 2020

Yeah, I thought you wanted to say that Verify should be implemented differently, but that was probably some miss-interpretation by me.

@NikVolf
Copy link
Contributor Author

NikVolf commented Apr 7, 2020

Updated to avoid mis-interpretations 👍

@NikVolf NikVolf mentioned this issue Apr 9, 2020
Merged
@bkchr bkchr mentioned this issue Jul 9, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I7-refactor Code needs refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make signature batching use specialized methods paritytech/substrate
2 participants
@NikVolf @bkchr