Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Metrics crate integration with Grafana data source #4187

Closed
expenses opened this issue Nov 22, 2019 · 6 comments
Closed

Metrics crate integration with Grafana data source #4187

expenses opened this issue Nov 22, 2019 · 6 comments
Labels
Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@expenses
Copy link
Contributor

The metrics crate provides a metrics-gathering facade similar to log. It would be great if we could integrate this with the Grafana data server from #3913, as we'd be able to easily switch it out for the prometheus observer or otherwise.

I'll probably end up doing this, but it should be fairly straightforward if anyone else wants to have a go.

@expenses expenses added Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. labels Nov 22, 2019
@pepyakin
Copy link
Contributor

I guess this might be related
сс @mattrutherford

@mattrutherford
Copy link
Contributor

Yes - looks like there is probably a lot of overlap with the tracing library that we just started to integrate #4132

Was thinking about adding a Receiver for substrate-tracing that can send to your Grafana data server.

Might be worth having a brain-storm some time to align on strategy for this stuff?

@expenses
Copy link
Contributor Author

Yup!

@expenses
Copy link
Contributor Author

I think we probably want to integrate the telemetry system into this as well.

@marcio-diaz
Copy link
Contributor

marcio-diaz commented Dec 5, 2019

From validators room:

anyone working on prometheus for polkadot? the current json datasource doesnt allow us to configure alert in grafana

@tomaka
Copy link
Contributor

tomaka commented Jun 11, 2020

Now that Prometheus is well in place, I suppose we can close this issue?
Feel free to reopen if not.

@tomaka tomaka closed this as completed Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
None yet
Development

No branches or pull requests

5 participants