Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Get rid of all the <weight> docs in FRAME #13261

Closed
kianenigma opened this issue Jan 28, 2023 · 4 comments · Fixed by #13350
Closed

Get rid of all the <weight> docs in FRAME #13261

kianenigma opened this issue Jan 28, 2023 · 4 comments · Fixed by #13350
Labels
Z0-trivial Writing the issue is of the same difficulty as patching the code. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@kianenigma
Copy link
Contributor

as they are all super stale, and don't serve any purpose now that we have benchmarking.

a dispatchable could still expose its complexity as:

/// Docs.
///
/// More docs.
///
/// ## Complexity
/// stuff
fn dispatch(origin: _, ..) -> {

But the current <weight> stuff is really garbage.

Note that this should reduce the size of the metadata and ergo the wasm blob as the consequence, the PR closing this can and should benchmark the difference.

@kianenigma kianenigma added Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Jan 28, 2023
@bkchr
Copy link
Member

bkchr commented Jan 28, 2023

Note that this should reduce the size of the metadata and ergo the wasm blob as the consequence, the PR closing this can and should benchmark the difference.

Benchmark what difference?

@kianenigma
Copy link
Contributor Author

Note that this should reduce the size of the metadata and ergo the wasm blob as the consequence, the PR closing this can and should benchmark the difference.

Benchmark what difference?

Size of the metadata and the wasm blob.

@bkchr
Copy link
Member

bkchr commented Jan 29, 2023

This should be really neglectable. If we add one new pallet to a runtime we probably add more stuff than what this weight stuff changes :P

@kianenigma
Copy link
Contributor Author

Sure sure, reducing the size is not the main purpose either. The main purpose is the clear up the noise.

@kianenigma kianenigma added Z0-trivial Writing the issue is of the same difficulty as patching the code. and removed Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Jan 30, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z0-trivial Writing the issue is of the same difficulty as patching the code. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants