Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngAut] ReviewBot: Introduce more sophisticated approval rights #101

Closed
4 tasks done
Bullrich opened this issue Nov 17, 2023 · 3 comments
Closed
4 tasks done

[EngAut] ReviewBot: Introduce more sophisticated approval rights #101

Bullrich opened this issue Nov 17, 2023 · 3 comments
Assignees

Comments

@Bullrich
Copy link
Contributor

Bullrich commented Nov 17, 2023

As mentioned in polkadot-fellows/runtimes#93

  • Implement new logic, which will consider lower than 4 ranks into approval decision
  • dismiss some approvals with new commits
  • [optionally in this scope] notify some selected groups via specified communication channels for readiness for review

Tasks

Preview Give feedback
  1. Bullrich
  2. Fellows important
    Bullrich
@Bullrich Bullrich self-assigned this Nov 17, 2023
@mordamax mordamax changed the title Introduce more sophisticated approval rights [EngAut] Introduce more sophisticated approval rights Dec 4, 2023
@mordamax mordamax moved this from Draft to Open in Parity Roadmap Dec 4, 2023
@mordamax mordamax changed the title [EngAut] Introduce more sophisticated approval rights [EngAut] ReviewBot: Introduce more sophisticated approval rights Jan 22, 2024
@Bullrich
Copy link
Contributor Author

Bullrich commented Feb 5, 2024

The feature for having different voting power per fellow has been released in Added required score grouping to fellows reviews #113 and version 2.4.0 has been released

A PR to upgrade review bot has been created and this will resolve polkadot-fellows/runtimes#93 which requested this feature.

@mordamax
Copy link
Contributor

mordamax commented Feb 12, 2024

weekly update: no updates from last week (blocked with un-reviewed PRs on runtimes side)

@Bullrich
Copy link
Contributor Author

Update: polkadot-fellows/runtimes#168 has been merged, updating review bot to 2.4.0

@github-project-automation github-project-automation bot moved this from Open to Closed in Parity Roadmap Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants