Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Configuration of include and exclude as a dictionary #135

Closed
alvicsam opened this issue Aug 1, 2023 · 1 comment
Closed

Configuration of include and exclude as a dictionary #135

alvicsam opened this issue Aug 1, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@alvicsam
Copy link
Contributor

alvicsam commented Aug 1, 2023

Currently I'm working on monorepo and I need to merge all rules for 3 repos, so include line can look like:

  include: ^substrate/frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*|aura/.*))|^polkadot/runtime/(kusama|polkadot)/src/[^/]+\.rs$|^\.gitlab-ci\.yml|^(?!.*\.dic$|.*spellcheck\.toml$)scripts/ci/.*|^\.github/.*

Which is not human readable at all.

It would be nice to be able to configure it like this:

  include: 
    - ^substrate/frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*|aura/.*))
    - ^polkadot/runtime/(kusama|polkadot)/src/[^/]+\.rs$
    - ^\.gitlab-ci\.yml
    - ^(?!.*\.dic$|.*spellcheck\.toml$)scripts/ci/.*
    - ^\.github/.*
@alvicsam alvicsam added the enhancement New feature or request label Aug 1, 2023
@mutantcornholio
Copy link
Contributor

This feature is already a part of new review-bot, which is currently in development and will replace PRCR.

More info here: #114

@mutantcornholio mutantcornholio closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants