Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Groundwork for network protocol upgrades #4964

Closed
rphmeier opened this issue Feb 22, 2022 · 0 comments · Fixed by #5084
Closed

Groundwork for network protocol upgrades #4964

rphmeier opened this issue Feb 22, 2022 · 0 comments · Fixed by #5084
Labels
I8-refactor Code needs refactoring.

Comments

@rphmeier
Copy link
Contributor

rphmeier commented Feb 22, 2022

Allow peers to connect with different versions and make this transparent to subsystems. We also need to make sure that new message types can be added while retaining some backwards compatibility.

#3779 will require a network protocol upgrade in order to add more information to Seconded statements, dispute statements, the view, and the collator-protocol advertisement.

Subsystems should handle backwards-compatibility with peers on old versions.

Libp2p and sc-network already support version negotiation between peers, but we need to figure out how we'll make use of this in our code - how should v2 peers interact with v1 peers? Or vice-versa? Which message types should be reused?

cc @eskimor @drahnr (I know what we want to do but don't know how)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I8-refactor Code needs refactoring.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant