From 90d75fc22e545d996a0dfde40dd7b6fcf93678ca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastian=20K=C3=B6cher?= <info@kchr.de>
Date: Mon, 8 Apr 2024 10:05:48 +0200
Subject: [PATCH] Remove useless loop

---
 substrate/client/consensus/beefy/src/lib.rs | 46 ++++++++++-----------
 1 file changed, 22 insertions(+), 24 deletions(-)

diff --git a/substrate/client/consensus/beefy/src/lib.rs b/substrate/client/consensus/beefy/src/lib.rs
index 0b1998a26e16..2637481fbf3e 100644
--- a/substrate/client/consensus/beefy/src/lib.rs
+++ b/substrate/client/consensus/beefy/src/lib.rs
@@ -550,31 +550,29 @@ pub async fn start_beefy_gadget<B, BE, C, N, P, R, S>(
 	// select recoverable errors.
 	loop {
 		// Make sure to pump gossip engine while waiting for initialization conditions.
-		let worker_builder = loop {
-			futures::select! {
-				builder_init_result = BeefyWorkerBuilder::async_initialize(
-					backend.clone(),
-					runtime.clone(),
-					key_store.clone().into(),
-					metrics.clone(),
-					min_block_delta,
-					beefy_comms.gossip_validator.clone(),
-					&mut finality_notifications,
-					is_authority,
-				).fuse() => {
-					match builder_init_result {
-						Ok(builder) => break builder,
-						Err(e) => {
-							error!(target: LOG_TARGET, "🥩 Error: {:?}. Terminating.", e);
-							return
-						},
-					}
-				},
-				// Pump gossip engine.
-				_ = &mut beefy_comms.gossip_engine => {
-					error!(target: LOG_TARGET, "🥩 Gossip engine has unexpectedly terminated.");
-					return
+		let worker_builder = futures::select! {
+			builder_init_result = BeefyWorkerBuilder::async_initialize(
+				backend.clone(),
+				runtime.clone(),
+				key_store.clone().into(),
+				metrics.clone(),
+				min_block_delta,
+				beefy_comms.gossip_validator.clone(),
+				&mut finality_notifications,
+				is_authority,
+			).fuse() => {
+				match builder_init_result {
+					Ok(builder) => builder,
+					Err(e) => {
+						error!(target: LOG_TARGET, "🥩 Error: {:?}. Terminating.", e);
+						return
+					},
 				}
+			},
+			// Pump gossip engine.
+			_ = &mut beefy_comms.gossip_engine => {
+				error!(target: LOG_TARGET, "🥩 Gossip engine has unexpectedly terminated.");
+				return
 			}
 		};