Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench-bot: accept multiple runtimes and multiple chain types for Cumulus #68

Closed
joao-paulo-parity opened this issue Jul 25, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@joao-paulo-parity
Copy link
Contributor

Problem: The current syntax for Cumulus commands is

/cmd queue -c bench-bot $ pallet runtime chain_type pallet_name

which means that users are only allowed to specify one runtime and one chain_type per command.

While it's possible to benchmark multiple runtimes and chain_types through multiple commands, as demonstrated in paritytech/cumulus#1460 (comment), that is inconvenient since the first job which finishes will push a commit, therefore jobs which finish after it won't be able to push the commit because the HEAD of the branch has changed.

Solution: allow for specifying multiple runtimes and chain_types in a single command. For example:

/cmd queue -v -c bench-bot $ pallet statemine,westmint assets,contracts pallet_uniques

where multiple runtimes and chain_types can be concatenated by , or + or whatever.


This feature might be interesting for Polkadot as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants