Skip to content
This repository was archived by the owner on Sep 14, 2023. It is now read-only.

add assertions to examples #509

Closed
harrysolovay opened this issue Jan 23, 2023 · 3 comments · Fixed by #826
Closed

add assertions to examples #509

harrysolovay opened this issue Jan 23, 2023 · 3 comments · Fixed by #826
Assignees
@harrysolovay

Comments

@harrysolovay
Copy link
Contributor

Will make our example-based testing approach more robust.
@ryanleecode ryanleecode mentioned this issue Jan 24, 2023
Merged
@harrysolovay
Copy link
Contributor Author

TODO: assign nythrox upon his being added to the paritytech org

@harrysolovay
Copy link
Contributor Author

Given that our examples can also serve as tests, it might be a good idea to add assertions to the examples. Granted, this could also bloat otherwise-clean examples... it's a delicate tradeoff. Is this worth pursuing?

@tjjfvi
Copy link
Contributor

tjjfvi commented Feb 21, 2023

I think it's worthwhile as long as the assertions also make the expected behavior of the examples clearer.

@harrysolovay harrysolovay mentioned this issue Feb 23, 2023
Closed
@harrysolovay harrysolovay assigned harrysolovay and unassigned nythrox Mar 31, 2023
@harrysolovay harrysolovay mentioned this issue Mar 31, 2023
Merged
@github-project-automation github-project-automation bot moved this to Done in Capi Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@harrysolovay harrysolovay

Labels
None yet
Projects
Capi
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: example reworking, additions, comments and assertions paritytech/capi
3 participants
@harrysolovay @nythrox @tjjfvi