Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parcel 2: Both flat and heirarchical source files showing for Typescript project #7876

Closed
toby-griffiths opened this issue Mar 29, 2022 · 2 comments · Fixed by #8734
Closed

Comments

@toby-griffiths
Copy link

toby-griffiths commented Mar 29, 2022

🐛 bug report

When working in dev mode, the links on console messages, or breakpoints don't display the source Typescript source files, but an error about not being able to load the source file. It seems that the source files are being listed twice in the Debugger pane. Once as a flat list, and once in the folder structure as found in the repository.

🎛 Configuration (.babelrc, package.json, cli command)

we don't currently have a .babelrc file. Here is our package.json file…

{
    "name": "good-crm-portals",
    "version": "1.0.0",
    "description": "",
    "scripts": {
        "dev": "parcel src/index.html --https",
    },
    "source": "src/index.html",
    "devDependencies": {
        "@parcel/transformer-svg-react": "^2.3.2",
        "@parcel/transformer-typescript-tsc": "^2.3.2",
        "@tailwindcss/forms": "^0.4.0",
        "@tailwindcss/typography": "^0.5.2",
        "@types/react": "^17.0.39",
        "@types/react-dom": "^17.0.11",
        "@typescript-eslint/eslint-plugin": "^5.13.0",
        "@typescript-eslint/parser": "^5.13.0",
        "autoprefixer": "^10.4.2",
        "eslint": "^8.10.0",
        "eslint-config-airbnb": "^19.0.4",
        "eslint-config-airbnb-typescript": "^16.1.0",
        "eslint-config-prettier": "^8.4.0",
        "eslint-plugin-import": "^2.25.4",
        "eslint-plugin-jsx-a11y": "^6.5.1",
        "eslint-plugin-prettier": "^4.0.0",
        "eslint-plugin-react": "^7.29.2",
        "eslint-plugin-react-hooks": "^4.3.0",
        "parcel": "^2.3.2",
        "postcss": "^8.4.6",
        "prettier": "^2.5.1",
        "prettier-plugin-tailwindcss": "^0.1.8",
        "tailwindcss": "^3.0.23",
        "typescript": "^4.5.5"
    },
    "dependencies": {
        "@fortawesome/fontawesome-svg-core": "^1.3.0",
        "@fortawesome/free-solid-svg-icons": "^6.0.0",
        "@fortawesome/react-fontawesome": "^0.1.17",
        "@headlessui/react": "^1.5.0",
        "@types/node": "^17.0.21",
        "react": "^17.0.2",
        "react-dom": "^17.0.2",
        "react-router-dom": "^6.2.2",
        "unstated-next": "^1.1.0"
    }
}
// tsconfig.json
{
    "compilerOptions": {
        /* Visit https://aka.ms/tsconfig.json to read more about this file */

        /* Basic Options */
        // "incremental": true,                         /* Enable incremental compilation */
        "target": "ES2021" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', 'ES2021', or 'ESNEXT'. */,
        "module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', 'es2020', or 'ESNext'. */,
        // "lib": [],                                   /* Specify library files to be included in the compilation. */
        // "allowJs": true,                             /* Allow javascript files to be compiled. */
        "checkJs": true /* Report errors in .js files. */,
        "jsx": "react-jsx" /* Specify JSX code generation: 'preserve', 'react-native', 'react', '' or 'react-jsxdev'. */,
        // "declaration": true,                         /* Generates corresponding '.d.ts' file. */
        // "declarationMap": true,                      /* Generates a sourcemap for each corresponding '.d.ts' file. */
        // "sourceMap": true,                           /* Generates corresponding '.map' file. */
        // "outFile": "./",                             /* Concatenate and emit output to single file. */
        // "outDir": "./",                              /* Redirect output structure to the directory. */
        // "rootDir": "./",                             /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */
        // "composite": true,                           /* Enable project compilation */
        // "tsBuildInfoFile": "./",                     /* Specify file to store incremental compilation information */
        "removeComments": true /* Do not emit comments to output. */,
        "noEmit": true /* Do not emit outputs. */,
        // "importHelpers": true,                       /* Import emit helpers from 'tslib'. */
        // "downlevelIteration": true,                  /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */
        "isolatedModules": true /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */,

        /* Strict Type-Checking Options */
        "strict": true /* Enable all strict type-checking options. */,
        // "noImplicitAny": true,                       /* Raise error on expressions and declarations with an implied 'any' type. */
        // "strictNullChecks": true,                    /* Enable strict null checks. */
        // "strictFunctionTypes": true,                 /* Enable strict checking of function types. */
        // "strictBindCallApply": true,                 /* Enable strict 'bind', 'call', and 'apply' methods on functions. */
        // "strictPropertyInitialization": true,        /* Enable strict checking of property initialization in classes. */
        // "noImplicitThis": true,                      /* Raise error on 'this' expressions with an implied 'any' type. */
        // "alwaysStrict": true,                        /* Parse in strict mode and emit "use strict" for each source file. */

        /* Additional Checks */
        // "noUnusedLocals": true,                      /* Report errors on unused locals. */
        // "noUnusedParameters": true,                  /* Report errors on unused parameters. */
        // "noImplicitReturns": true,                   /* Report error when not all code paths in function return a value. */
        // "noFallthroughCasesInSwitch": true,          /* Report errors for fallthrough cases in switch statement. */
        // "noUncheckedIndexedAccess": true,            /* Include 'undefined' in index signature results */
        // "noImplicitOverride": true,                  /* Ensure overriding members in derived classes are marked with an 'override' modifier. */
        // "noPropertyAccessFromIndexSignature": true,  /* Require undeclared properties from index signatures to use element accesses. */

        /* Module Resolution Options */
        // "moduleResolution": "node",                  /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
        // "baseUrl": "./",                             /* Base directory to resolve non-absolute module names. */
        // "paths": {},                                 /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */
        // "rootDirs": [],                              /* List of root folders whose combined content represents the structure of the project at runtime. */
        // "typeRoots": [],                             /* List of folders to include type definitions from. */
        // "types": [],                                 /* Type declaration files to be included in compilation. */
        // "allowSyntheticDefaultImports": true,        /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
        "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */,
        // "preserveSymlinks": true,                    /* Do not resolve the real path of symlinks. */
        // "allowUmdGlobalAccess": true,                /* Allow accessing UMD globals from modules. */

        /* Source Map Options */
        // "sourceRoot": "",                            /* Specify the location where debugger should locate TypeScript files instead of source locations. */
        // "mapRoot": "",                               /* Specify the location where debugger should locate map files instead of generated locations. */
        // "inlineSourceMap": true,                     /* Emit a single file with source maps instead of having a separate file. */
        // "inlineSources": true,                       /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */

        /* Experimental Options */
        // "experimentalDecorators": true,              /* Enables experimental support for ES7 decorators. */
        // "emitDecoratorMetadata": true,               /* Enables experimental support for emitting type metadata for decorators. */

        /* Advanced Options */
        "skipLibCheck": true /* Skip type checking of declaration files. */,
        "forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */
    }
}

🤔 Expected Behavior

When clicking a link against a console message, or code stops at a debugger line, then the relevant source file is displayed in the Debugger panel. This should be the one under the /src directory in the repo.

😯 Current Behavior

The file with the correct file name is loaded, but from the flat list of files, not the ones under the /src directory, and an error is displayed. See video…

Screen.Recording.2022-03-29.at.11.08.44.mov

Here is the error displayed…

Error while fetching an original source: request failed with status 404
Source URL: <unknown>

💁 Possible Solution

I need to work out why there are both flat, and duplicate heirarchically organised source files, and how to get the debugger pane to display the heirarchical ones that actually load.

🔦 Context

I'm unable to debug issues with my code, for example why a method is being called twice, rather than just the once.

💻 Code Sample

Repo: https://github.com/toby-griffiths/parcel-typescript-sourcefile-bug

🌍 Your Environment

Software Version(s)
Parcel 2.4.0
Node v17.4.0
npm/Yarn yarn 1.22.17
Operating System Mac OSX 12.2.1
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs.

@github-actions github-actions bot added the Stale Inactive issues label Sep 26, 2022
@github-actions github-actions bot removed the Stale Inactive issues label Feb 5, 2023
@valepu
Copy link

valepu commented Feb 5, 2023

I had this same issue and even if this was closed as completed I couldn't find how, I kept searching through the issues/merges and I found this #8734 which solves the issue. I have update Parcel to 2.8.3 (from 2.8.2) and it works now. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants