Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phar is missing from recent releases #598

Closed
jakzal opened this issue Feb 25, 2021 · 8 comments
Closed

phar is missing from recent releases #598

jakzal opened this issue Feb 25, 2021 · 8 comments
Labels

Comments

@jakzal
Copy link

jakzal commented Feb 25, 2021

Q A
ParaTest version >5.0.4
PHPUnit version -
PHP version -

Summary

The latest release with published phar is 5.0.4.

@jakzal jakzal added the bug label Feb 25, 2021
@jakzal jakzal changed the title phar is missing from recent release phar is missing from recent releases Feb 25, 2021
@Slamdunk
Copy link
Member

Hi, PHAR release has been dropped since it has no meaning in the context of this very tool.

@Slamdunk Slamdunk added wontfix and removed bug labels Feb 25, 2021
@jakzal
Copy link
Author

jakzal commented Feb 25, 2021

What do you mean y "it has no meaning"?

@Slamdunk
Copy link
Member

Paratest needs the PHPUnit binary to run the sub-processes, the exact one the user chose to include in its composer.json, we can't embed it

@tPl0ch
Copy link

tPl0ch commented Aug 28, 2023

Sorry, but it wouldn't be hard to make this configurable, right? We could just pass the binary from the composer path as an argument, or am I missing something?

Why? We can't install paratest currently through composer due to the fixed versions of symfony/consoleand symfony/process. We are still running Symfony 5.4 LTS, and, since we recently switched from PHPUnit 9 to 10, it becomes uninstallable due to the version constraints.

@Slamdunk
Copy link
Member

It is two orders of magnitude easier and quicker for you to upgrade symfony/console and symfony/process from 5.4 to 6.0 then for us to provide a comprehensive and reliable PHAR solution and to maintain it for the rest of our lives.

@tPl0ch
Copy link

tPl0ch commented Aug 31, 2023

@Slamdunk that's a pretty bold assumption. I disagree that migrating a multi-million LOC code base to a new major framework version is two orders of magnitude easier than maintaining a phar building CI job (which is a solved problem, just look at hundreds of other libraries doing it).

@Slamdunk
Copy link
Member

Slamdunk commented Aug 31, 2023

Symfony did a decent good job at creating self-contained packages. You can keep the framework components at version 5.4 while upgrading console and process ones:

  1. console has only one cross-dependency pinned with both versions supported (https://github.com/symfony/console/blob/6.3/composer.json#L23)
  2. process has no dependency at all (https://github.com/symfony/process/blob/6.3/composer.json#L18-L20)

Regarding the PHAR, the fact that is a solved problem doesn't wipe out that is a tricky and exhausting one.

@Jean85
Copy link
Collaborator

Jean85 commented Sep 1, 2023

Also, big difference: you're probably paid to migrate that multi-million LOC codebase.

We're not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants