You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OpEthApi should wrap EthApiInner<...>, just like EthApi struct does, instead of the generic Eth. Calling Eth::some_trait_method in implementation of EthApiServer helper traits is bug prone, since any default trait method overrides for OpEthApi, won't be considered if called inside scope of Eth::some_trait_method.
Additional context
No response
The text was updated successfully, but these errors were encountered:
for OP I can use FullNodeComponents though to unify the generics Provider, Pool, Evm, we just didn't make that change for EthApi because it would require a lot of work fixing existing tests
Describe the feature
OpEthApi
should wrapEthApiInner<...>
, just likeEthApi
struct does, instead of the genericEth
. CallingEth::some_trait_method
in implementation ofEthApiServer
helper traits is bug prone, since any default trait method overrides forOpEthApi
, won't be considered if called inside scope ofEth::some_trait_method
.Additional context
No response
The text was updated successfully, but these errors were encountered: