Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove transaction forwarder trait #9562

Closed
mattsse opened this issue Jul 16, 2024 · 2 comments · Fixed by #9678
Closed

remove transaction forwarder trait #9562

mattsse opened this issue Jul 16, 2024 · 2 comments · Fixed by #9678
Assignees
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 16, 2024

Describe the feature

now that we have separate ethapi impls for op and eth, we no longer need this

pub trait RawTransactionForwarder: fmt::Debug + Send + Sync + 'static {
/// Forwards raw transaction bytes for `eth_sendRawTransaction`
async fn forward_raw_transaction(&self, raw: &[u8]) -> EthResult<()>;
}
/// Configure server's forwarder for `eth_sendRawTransaction`, at runtime.
pub trait UpdateRawTxForwarder {

TODO

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Jul 16, 2024
@mattsse mattsse added A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels Jul 16, 2024
@nkysg
Copy link
Contributor

nkysg commented Jul 17, 2024

May I take this?

@EmmanuelAR
Copy link

Hello @mattsse

My name is Emmanuel, a software developer from Costa Rica. I would be happy to assist with this task. I will review the current implementation and will guide by the comments that you post in the ticket

Please let me know if this is acceptable.

Best regards,
Emmanuel 😁

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain and removed C-enhancement New feature or request labels Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants