Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TxType variants to UpperCamelCase (PascalCase) #7006

Closed
DaniPopes opened this issue Mar 6, 2024 · 1 comment · Fixed by #7012
Closed

Rename TxType variants to UpperCamelCase (PascalCase) #7006

DaniPopes opened this issue Mar 6, 2024 · 1 comment · Fixed by #7012
Assignees
@AbnerZheng
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@DaniPopes
Copy link
Member

Describe the feature

Enum variants are UpperCamelCase in Rust. Acronyms count as one word.

Additional context

In UpperCamelCase, acronyms and contractions of compound words count as one word: use Uuid rather than UUID, Usize rather than USize or Stdin rather than StdIn
@DaniPopes DaniPopes added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Mar 6, 2024
@AbnerZheng
Copy link
Contributor

Will give it a try.

@AbnerZheng AbnerZheng mentioned this issue Mar 6, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbnerZheng AbnerZheng

Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename TxType variants to UpperCamelCase AbnerZheng/reth
2 participants
@AbnerZheng @DaniPopes