Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hive correct_increasing and correct_decreasing blob gas cost tests fail #4816

Closed
1 task done
Tracked by #4812
Rjected opened this issue Sep 27, 2023 · 1 comment
Closed
1 task done
Tracked by #4812
Assignees
Labels
A-execution Related to the Execution and EVM C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test E-cancun Related to the Cancun network upgrade

Comments

@Rjected
Copy link
Member

Rjected commented Sep 27, 2023

Describe the bug

The pyspec tests:

  • cancun/eip4844_blobs/excess_blob_gas/correct_increasing_blob_gas_costs
  • cancun/eip4844_blobs/excess_blob_gas/correct_decreasing_blob_gas_costs

fail with the following invalid state root error:

>> (db999f90) {"jsonrpc":"2.0","id":1,"method":"eth_getBlockByNumber","params":["0x0",true]}
<< (db999f90) {"jsonrpc":"2.0","result":{"hash":"0x048dbfff9c0f2fdfb8429275fd1515174aaf26cb1ecebd46c62d4fadc255862d","parentHash":"0x0000000000000000000000000000000000000000000000000000000000000000","sha3Uncles":"0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347","miner":"0x0000000000000000000000000000000000000000","stateRoot":"0x0e751bd2dbc3d2237336ed1557e91d2809492baf7a7ed92a17b175187711fa92","transactionsRoot":"0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421","receiptsRoot":"0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421","logsBloom":"0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","difficulty":"0x0","number":"0x0","gasLimit":"0x16345785d8a0000","gasUsed":"0x0","timestamp":"0x0","extraData":"0x00","mixHash":"0x0000000000000000000000000000000000000000000000000000000000000000","nonce":"0x0000000000000000","baseFeePerGas":"0x7","withdrawalsRoot":"0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421","blobGasUsed":"0x0","excessBlobGas":"0x6820000","parentBeaconBlockRoot":"0x0000000000000000000000000000000000000000000000000000000000000000","totalDifficulty":"0x0","uncles":[],"transactions":[],"size":"0x247","withdrawals":[]},"id":1}
>> (db999f90) {"jsonrpc":"2.0","id":1,"method":"engine_newPayloadV3","params":[{"parentHash":"0x048dbfff9c0f2fdfb8429275fd1515174aaf26cb1ecebd46c62d4fadc255862d","feeRecipient":"0x2adc25665018aa1fe0e6bc666dac8fc2697ff9ba","stateRoot":"0x16589c2a82ab038f26524cbbaa119c1e9b72f4b6d659a1a31af16b44e81526cd","receiptsRoot":"0xeaa8c40899a61ae59615cf9985f5e2194f8fd2b57d273be63bde6733e89b12ab","logsBloom":"0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000","prevRandao":"0x0000000000000000000000000000000000000000000000000000000000000000","blockNumber":"0x1","gasLimit":"0x16345785d8a0000","gasUsed":"0x5208","timestamp":"0xc","extraData":"0x","baseFeePerGas":"0x7","blockHash":"0x74c3544bcd2d28601f91548c8dd02358a9c17563fffcc6373bf4a72519622458","transactions":["0x03f8ad018080078252089400000000000000000000000000000000000002000180c086811f2fd4afccf842a00100000000000000000000000000000000000000000000000000000000000000a0010000000000000000000000000000000000000000000000000000000000000180a0e1b86c3506e72dc441963576ba50e1bb672fea9519bae6933de882a0897f9d31a07cba0918812d017e8101eca34c9f50b16379b02d91c4a9f0c04b5f223e6d5b1f"],"withdrawals":[],"blobGasUsed":"0x40000","excessBlobGas":"0x67c0000"},["0x0100000000000000000000000000000000000000000000000000000000000000","0x0100000000000000000000000000000000000000000000000000000000000001"],"0x0000000000000000000000000000000000000000000000000000000000000000"]}
<< (db999f90) {"jsonrpc":"2.0","result":{"status":"INVALID","latestValidHash":"0x048dbfff9c0f2fdfb8429275fd1515174aaf26cb1ecebd46c62d4fadc255862d","validationError":"Block state root (0x5f395c1208d50a66a00bad3fe3a81ab8004cbefd15b109259e8c79ea23dab441) is different from expected: (0x16589c2a82ab038f26524cbbaa119c1e9b72f4b6d659a1a31af16b44e81526cd)"},"id":1}
payload status mismatch: client returned INVALID fixture expected VALID

Steps to reproduce

Run hive:

 ./hive --client reth --sim pyspec --sim.limit "/cancun/eip4844_blobs/excess_blob_gas/correct_"

Node logs

No response

Platform(s)

No response

What version/commit are you on?

No response

What database version are you on?

No response

If you've built Reth from source, provide the full command you used

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@Rjected Rjected added C-bug An unexpected or incorrect behavior S-needs-investigation This issue requires detective work to figure out what's going wrong A-execution Related to the Execution and EVM C-test A change that impacts how or what we test E-cancun Related to the Cancun network upgrade M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity labels Sep 27, 2023
@Rjected Rjected self-assigned this Sep 27, 2023
@Rjected
Copy link
Member Author

Rjected commented Sep 28, 2023

fixed by bluealloy/revm#757

@Rjected Rjected removed M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity S-needs-investigation This issue requires detective work to figure out what's going wrong labels Sep 28, 2023
@Rjected Rjected closed this as completed Sep 28, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test E-cancun Related to the Cancun network upgrade
Projects
Archived in project
Development

No branches or pull requests

1 participant