Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move compressors to reth-codecs #13248

Closed
mattsse opened this issue Dec 9, 2024 · 0 comments · Fixed by #13250
Closed

Move compressors to reth-codecs #13248

mattsse opened this issue Dec 9, 2024 · 0 comments · Fixed by #13250
Assignees
@mattsse
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Dec 9, 2024

Describe the feature

we need to reuse the same compressors for both eth and op types and reth-primitives (temporarily)

so this should be moved to reth-codecs

reth/crates/primitives/src/compression/mod.rs

Line 3 in 3c13295

use zstd::bulk::{Compressor, Decompressor};

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Dec 9, 2024
@mattsse mattsse added A-sdk Related to reth's use as a library and removed S-needs-triage This issue needs to be labelled labels Dec 9, 2024
@mattsse mattsse self-assigned this Dec 9, 2024
@mattsse mattsse mentioned this issue Dec 9, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsse mattsse

Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: extract zstd compressors paradigmxyz/reth
1 participant
@mattsse