Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to replace sender's transactions if capacity reached #11922

Closed
klkvr opened this issue Oct 21, 2024 · 1 comment · Fixed by #11931
Closed

Not possible to replace sender's transactions if capacity reached #11922

klkvr opened this issue Oct 21, 2024 · 1 comment · Fixed by #11931
Assignees
Labels
A-tx-pool Related to the transaction mempool C-bug An unexpected or incorrect behavior C-enhancement New feature or request

Comments

@klkvr
Copy link
Collaborator

klkvr commented Oct 21, 2024

Describe the feature

Right now if sender has its tx capacity reached we'll reject all of its transactions

if current_txs >= self.max_account_slots {

This is an issue when capacity is filled with transactions which nonce is greater than current sender nonce and which can never be included on its own. We should always allow transactions with the next onchain sender's nonce

Additional context

No response

@klkvr klkvr added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 21, 2024
@klkvr klkvr added the C-bug An unexpected or incorrect behavior label Oct 21, 2024
@mattsse mattsse added A-tx-pool Related to the transaction mempool and removed S-needs-triage This issue needs to be labelled labels Oct 21, 2024
@mattsse
Copy link
Collaborator

mattsse commented Oct 21, 2024

@klkvr we should check here if the new txs fills a nonce gap from on chain nonce to the pooled txs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-bug An unexpected or incorrect behavior C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants