trie: inconsistent SparseTrie::update_rlp_node_level behavior

[rkrasiuk]

Description

SparseTrie::update_rlp_node_level is meant as a public interface to perform a minimal amount of work as requested by the caller. It is meant to perform partial node hash computations in case the final output state becomes available in chunks.

Fix inconsistent behavior introduced by min_len checks. Perhaps, migrate this method to accept desired depth instead.

reth/crates/trie/sparse/src/trie.rs

Lines 277 to 316 in 6b2ec42

	/// Update node hashes only if their path exceeds the provided level.
	pub fn update_rlp_node_level(&mut self, min_len: usize) {
	let mut paths = Vec::from([Nibbles::default()]);
	let mut targets = HashSet::<Nibbles>::default();
	while let Some(mut path) = paths.pop() {
	match self.nodes.get(&path).unwrap() {
	SparseNode::Empty | SparseNode::Hash(_) => {}
	SparseNode::Leaf { .. } => {
	targets.insert(path);
	}
	SparseNode::Extension { key, .. } => {
	if path.len() >= min_len {
	targets.insert(path);
	} else {
	path.extend_from_slice_unchecked(key);
	paths.push(path);
	}
	}
	SparseNode::Branch { state_mask, .. } => {
	if path.len() >= min_len {
	targets.insert(path);
	} else {
	for bit in CHILD_INDEX_RANGE {
	if state_mask.is_bit_set(bit) {
	let mut child_path = path.clone();
	child_path.push_unchecked(bit);
	paths.push(child_path);
	}
	}
	}
	}
	}
	}
	let mut prefix_set = self.prefix_set.clone().freeze();
	for target in targets {
	self.rlp_node(target, &mut prefix_set);
	}
	}