Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-4844 RPC receipt for Optimism #11619

Closed
shekhirin opened this issue Oct 9, 2024 · 2 comments
Closed

EIP-4844 RPC receipt for Optimism #11619

shekhirin opened this issue Oct 9, 2024 · 2 comments
Labels
A-op-reth Related to Optimism and op-reth C-debt Refactor of code section that is hard to understand or maintain S-stale This issue/PR is stale and will close with no further activity

Comments

@shekhirin
Copy link
Collaborator

Describe the feature

reth/crates/optimism/rpc/src/eth/receipt.rs

Lines 259 to 262 in 076b1a2

TxType::Eip4844 => {
// TODO: unreachable
OpReceiptEnvelope::<Log>::Eip1559(receipt_with_bloom)
}

#11617 (comment)

Additional context

No response
@shekhirin shekhirin added C-debt Refactor of code section that is hard to understand or maintain A-op-reth Related to Optimism and op-reth labels Oct 9, 2024
@shekhirin shekhirin self-assigned this Oct 9, 2024
@shekhirin shekhirin removed their assignment Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Nov 8, 2024
@mattsse
Copy link
Collaborator

mattsse commented Nov 13, 2024

marking this as completed because in reality unreachable and will go away naturally once we have network specific tx types

@mattsse mattsse closed this as completed Nov 13, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth C-debt Refactor of code section that is hard to understand or maintain S-stale This issue/PR is stale and will close with no further activity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shekhirin @mattsse