Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper NetworkBuilder that allows overriding certain settings #11504

Closed
mattsse opened this issue Oct 5, 2024 · 1 comment
Closed

Add a helper NetworkBuilder that allows overriding certain settings #11504

mattsse opened this issue Oct 5, 2024 · 1 comment
Assignees
Labels
C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 5, 2024

Describe the feature

the NetworkBuilder is responsible for building the network instance:

impl<Node, Pool> NetworkBuilder<Node, Pool> for OptimismNetworkBuilder
where
Node: FullNodeTypes<Types: NodeTypes<ChainSpec = OpChainSpec>>,
Pool: TransactionPool + Unpin + 'static,
{
async fn build_network(
self,
ctx: &BuilderContext<Node>,
pool: Pool,
) -> eyre::Result<NetworkHandle> {

currently we don't have an easy way to simply override certain settings, e.g. in config.

A helper type that contains certain settings of NetworkArgs would be beneficial here, without having to reimplement the entire thing.

Additional context

paradigmxyz/alphanet#134

FYI @onbjerg

No response

@onbjerg
Copy link
Member

onbjerg commented Oct 8, 2024

Is this resolved in #11506 and #11507 or is there more left?

@mattsse mattsse closed this as completed Oct 24, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants