Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Eth/Op PayloadTypes impl #11490

Closed
mattsse opened this issue Oct 4, 2024 · 1 comment · Fixed by #11558
Closed

Introduce Eth/Op PayloadTypes impl #11490

mattsse opened this issue Oct 4, 2024 · 1 comment · Fixed by #11558
Assignees
Labels
A-block-building Related to block building C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 4, 2024

Describe the feature

what we want here

pub struct EthEngineTypes;
impl PayloadTypes for EthEngineTypes {
type BuiltPayload = EthBuiltPayload;
type PayloadAttributes = EthPayloadAttributes;
type PayloadBuilderAttributes = EthPayloadBuilderAttributes;
}
impl EngineTypes for EthEngineTypes {
type ExecutionPayloadV1 = ExecutionPayloadV1;
type ExecutionPayloadV2 = ExecutionPayloadEnvelopeV2;
type ExecutionPayloadV3 = ExecutionPayloadEnvelopeV3;
type ExecutionPayloadV4 = ExecutionPayloadEnvelopeV4;
}

is something like

pub struct EthEngineTypes<T:PayloadTypes = EthPayloadTypes>;

impl<T: PayloadTypes> PayloadTypes for EthEngineTypes<T> {
    type BuiltPayload = T::BuiltPayload;
    type PayloadAttributes = T::PayloadAttributes;
    type PayloadBuilderAttributes = T::PayloadBuilderAttributes;
}


struct EthPayloadTypes;
impl PayloadTypes for EthPayloadTypes {
    type BuiltPayload = EthBuiltPayload;
    type PayloadAttributes = EthPayloadAttributes;
    type PayloadBuilderAttributes = EthPayloadBuilderAttributes;
} 

same for OP

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 4, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-block-building Related to block building and removed S-needs-triage This issue needs to be labelled labels Oct 4, 2024
@stevencartavia
Copy link
Contributor

Hi, can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants