Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup prepare_call_env function #11464

Closed
mattsse opened this issue Oct 3, 2024 · 1 comment · Fixed by #11469
Closed

Cleanup prepare_call_env function #11464

mattsse opened this issue Oct 3, 2024 · 1 comment · Fixed by #11469
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 3, 2024

Describe the feature

this currently accepts a gas limit field:

however we only call this with the configured call gas limit:

/// Returns default gas limit to use for `eth_call` and tracing RPC methods.
///
/// Data access in default trait method implementations.
fn call_gas_limit(&self) -> u64;

so this arg is kinda pointless.

also we should not disable gas_limit, because that's an anvil relict where this is safe.

TODO:

  • remove gas_limit arg
  • remove disable gas_limit setting

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 3, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Oct 3, 2024
@varun-doshi
Copy link
Contributor

I can take this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants