Remove multi provider trait functions in rpc helper traits

[mattsse]

Describe the feature

we compose various rpc traits with default impls

like:

reth/crates/rpc/rpc-eth-api/src/helpers/trace.rs

Line 22 in a07efa7

pub trait Trace: LoadState {

these are effective stacked traits.
currently we have some functions multiple times:

reth/crates/rpc/rpc-eth-api/src/helpers/trace.rs

Line 26 in a07efa7

fn evm_config(&self) -> &impl ConfigureEvm<Header = Header>;

reth/crates/rpc/rpc-eth-api/src/helpers/call.rs

Line 459 in a07efa7

fn evm_config(&self) -> &impl ConfigureEvm<Header = Header>;

or

reth/crates/rpc/rpc-eth-api/src/helpers/transaction.rs

Line 56 in a07efa7

fn provider(&self) -> impl BlockReaderIdExt;

reth/crates/rpc/rpc-eth-api/src/helpers/pending_block.rs

Lines 47 to 52 in a07efa7

	fn provider(
	&self,
	) -> impl BlockReaderIdExt
	+ EvmEnvProvider
	+ ChainSpecProvider<ChainSpec: EthChainSpec + EthereumHardforks>
	+ StateProviderFactory;

resulting in some inconvenient usage and restrictions.

like:

reth/crates/rpc/rpc-eth-api/src/helpers/block.rs

Line 154 in a07efa7

LoadBlock::provider(self).ommers_by_id(block_id).map_err(Self::Error::from_eth_err)

ideally we only have one evm_config and one provider function, perhaps in a single trait that sits at the bottom of the stack, these should like by an associated type and we can easily implement this because we have this generic:

reth/crates/rpc/rpc/src/eth/helpers/transaction.rs

Lines 13 to 23 in a07efa7

	impl<Provider, Pool, Network, EvmConfig> EthTransactions
	for EthApi<Provider, Pool, Network, EvmConfig>
	where
	Self: LoadTransaction,
	Pool: TransactionPool + 'static,
	Provider: BlockReaderIdExt,
	{
	#[inline]
	fn provider(&self) -> impl BlockReaderIdExt {
	self.inner.provider()
	}

and it is expected that the final provider is then the full provider that satisfies all traits.

the stacked traits can then add the required bounds

trait EthCore // naming tbd {
  type Provider;
  type Evm;

  fn provider(&self) -> &Self::Provider;
  fn evm_config...
}

then we can force the required trait bounds on Trace for example

trait Trace: EthCore<Provider: ....> {

}

Additional context

No response

Tasks

Preview Give feedback

1. chore(rpc): Remove provider and network trait methods from EthApiSpec #12050
   A-rpc A-sdk C-debt +3
2. chore(rpc): set RpcNodeCore as supertrait for LoadState #12094
   A-rpc A-sdk C-debt +3
3. Remove trait method Call::evm_config #12095
   A-rpc A-sdk C-debt +3
4. chore(rpc): Add super trait RpcNodeCore to LoadPendingBlock #12098
   A-rpc A-sdk C-debt +3
5. chore(rpc): remove redundant trait method LoadBlock::provider #12100
   A-rpc A-sdk C-debt +3
6. chore(rpc): add super trait RpcNodeCore to LoadTransaction #12104
   A-rpc A-sdk C-debt +3
7. chore(rpc): remove redundant Trace::evm_config #12102
   A-rpc A-sdk C-debt +3
8. chore(rpc): remove redundant EthBlocks::provider #12109
   A-rpc A-sdk C-debt +3
9. chore(rpc): remove redundant EthTransactions::provider #12121
   A-rpc A-sdk C-debt +3
10. chore(rpc): remove redundant LoadFee::provider #12122
    A-rpc A-sdk C-debt +3

[emhane]

something like this would be helpful: https://github.com/paradigmxyz/reth/pull/10616/files

then moving all the getters in FullNodeComponents to this trait.

removing this redundancy at the price of making the the trait bounds less precise, isn't helpful. Some rollups won't use all the FullProvider, only certain providers. it's nice sdk if they don't have to do lots of noop impl of provider traits they aren't using on their provider type.

besides it makes it harder to build unit tests for this code, which we should aim to do despite hive test coverage.

[mattsse]

right, #10616 is more or less the unlock here, or similar at least

[github-actions]

This issue is stale because it has been open for 21 days with no activity.