Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote PayloadBuilder to component type #10434

Closed
1 task done
mattsse opened this issue Aug 22, 2024 · 0 comments · Fixed by #11529
Closed
1 task done

Promote PayloadBuilder to component type #10434

mattsse opened this issue Aug 22, 2024 · 0 comments · Fixed by #11529
Assignees
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 22, 2024

Describe the feature

similar to #9872 and #9921

it would be nice to do the same for PayloadBuilderHandle

fn payload_builder(&self) -> &PayloadBuilderHandle<NodeTypes::Engine>;

this should be possible by mimicking #9921 and also introducing traits for PayloadBuilderAPI

This way we should be able to easily integrate this into rpc and phase out our manual pending block-building, for which we'd need to do some additional changes I think, like returning receipts

Additional context

No response

Tasks

Preview Give feedback
  1. A-block-building C-debt D-good-first-issue
    greged93
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Aug 22, 2024
@mattsse mattsse added A-sdk Related to reth's use as a library and removed S-needs-triage This issue needs to be labelled labels Aug 22, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants