New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Journal gets completely wiped after error #17

Closed

DanielSchiavini opened this issue May 3, 2024 · 0 comments · Fixed by #18

Contributor

DanielSchiavini commented May 3, 2024 •

edited

Loading

When any kind of revert happens, (py)revm is dropping the whole journal instead of keeping the data before the revert.

Reproduction scenario

    evm = EVM()
    snapshot = evm.snapshot()

    with pytest.raises(RuntimeError):
        evm.message_call(
            caller=address,
            to=address,
            value=1,  # raises LackOfFundForMaxFee
        )

    evm.revert(snapshot)  # raises OverflowError: No checkpoint to revert to

DanielSchiavini changed the title ~~Journal gets completely wiped after revert~~ Journal gets completely wiped after error

This was referenced May 3, 2024

Fix lack of fund errors charles-cooper/vyper#35

Merged

fix: Save evm context after errors #18

Merged

charles-cooper closed this as completed in #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment