Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to show documentation when entering function parameters? #44

Closed
quantum-booty opened this issue Oct 23, 2020 · 3 comments · Fixed by #88
Closed

How to show documentation when entering function parameters? #44

quantum-booty opened this issue Oct 23, 2020 · 3 comments · Fixed by #88
Labels
help wanted Extra attention is needed

Comments

@quantum-booty
Copy link

quantum-booty commented Oct 23, 2020

I am using the jedi-ls with Nvim-lsp.
When using pyls, the documentation shows when I am writing function parameters, whereas jedi-ls only shows the signature help. How can I replicate the behaviour like in pyls?

Pyls:
image

Jedi-ls:
image

@pappasam
Copy link
Owner

Ah, this is something I'd ideally like to support, but I've run into some issues with nvim-lsp and its treatment of undefined values that has made me shy away from implementing this feature at this time.

In short, there's a pygls limitation at present where Python's None is treated as both Javascript undefined and null. nvim-lsp does not handle null and undefined in an elegant way, which will break your language server. To get around this / support Neovim's native language server, I've avoided adding this feature.

See #38

That said, if you were able to verify that Neovim's lsp implementation tolerates this ambiguity between null and undefined (coc currently tolerates it), I'd be happy to implement!

@pappasam pappasam added the help wanted Extra attention is needed label Oct 26, 2020
@pappasam
Copy link
Owner

Also see my pull request with pygls: openlawlibrary/pygls#132. It's been completely ignored, so I'm not sure solutions to this problem are being prioritized at this time.

@pappasam
Copy link
Owner

And here's the pygls issue: openlawlibrary/pygls#124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants