REF: initialize Series._name in _from_mgr to return valid Series object #55607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
approved these changes
Oct 25, 2023
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Looks like this PR has gone stale and needs a rebase so closing to clear the queue, but feel free to reopen when you have time to circle back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Series._from_mgrdoesn't return a fully initialized Series object, because it misses the_nameattribute (without this, several kinds of operations fail on the object).While
_from_mgris not a user-facing method, I think also from a developer perspective, it's nicer if it returns a proper Series, for example for during debugging, and for not having to think about setting_nameafter using it (as we are currently doing).