CoW: Add warning for chained assignment with fillna #53779
Merged
+72
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorisvandenbossche I'd appreciate if you can take a look locally, I can't reproduce these failures on Mac |
|
i get similar-looking failures on mac |
|
Arm or intel? Purged environment and still can't reproduce... |
|
intel |
|
Hm shit. Thx for checking |
|
This is Python version specific unfortunately... 3.10 has a different ref count compared to 3.11 |
| df = DataFrame({"a": [1, np.nan, 2], "b": 1}) | ||
| df_orig = df.copy() | ||
| if using_copy_on_write: | ||
| with tm.assert_produces_warning(ChainedAssignmentError): |
There was a problem hiding this comment.
There is a helper for this, with tm.raises_chained_assignment_error():, which will take care of the fact that it doesn't raise a warning on PyPy
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.