BUG: Arithmetic inplace ops not respecting CoW #51403
Conversation
pandas/core/generic.py
Outdated
| if ( | ||
| self.ndim == 1 | ||
| and result._indexed_same(self) | ||
| and is_dtype_equal(result.dtype, self.dtype) | ||
| and not ( |
There was a problem hiding this comment.
We could use iloc instead of checking for references, but would probably cost performance?
There was a problem hiding this comment.
Yeah, I think it is fine to use the manager method here (we can de-privatize if needed at some point)
There was a problem hiding this comment.
Actually, if you want to use an existing manager method that already takes care of this, on a SingleBlockManager, that would actually be self._mgr.setitem_inplace(slice(None), result._values)
That should translate to exactly the same (it only does an additional np_can_hold_element check, but I assume that should be cheap if the dtypes are equal, which is already checked above)
There was a problem hiding this comment.
I like this, switched over.
|
greenish |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.We should add tests for all op-possibilities in a follow up