Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BENCH: put in np.random.seed on vbenches #8144

Closed
jreback opened this issue Aug 29, 2014 · 6 comments · Fixed by #19148
Closed

BENCH: put in np.random.seed on vbenches #8144

jreback opened this issue Aug 29, 2014 · 6 comments · Fixed by #19148
Labels
good first issue Groupby Performance Memory or execution speed performance
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Aug 29, 2014

all of the groupby vbenches need a np.random.seed(1234) to make them consistent from run-to-run (where they don't have them now).

Possibly should do this on other benches as well.

@jreback jreback added this to the 0.15.0 milestone Aug 29, 2014
@hayd
Copy link
Contributor

hayd commented Aug 29, 2014

Could this just be stuck into pandas_vb_common ?

@jreback
Copy link
Contributor Author

jreback commented Aug 30, 2014

yes that should work
should remove any of the other ones
and test that it stays reasonably stable run to run

@jtratner
Copy link
Contributor

jtratner commented Sep 7, 2014

👍

@jreback jreback modified the milestones: 0.15.1, 0.15.0 Sep 16, 2014
@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 6, 2015
@RafalSkolasinski
Copy link
Contributor

I am working on that now

@RafalSkolasinski
Copy link
Contributor

Ok, that looks like already taken care of. There is np.random.seed(1234) on vbanches and also new asv_banches.

@jreback
Copy link
Contributor Author

jreback commented Aug 30, 2015

need to remove any randoms from existing benchmarks, and ensure that they still run. E.g. we always want to use a single seed for the entire run (unless for some reason a benchmark uses a very specific seed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Groupby Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants