Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io.rst needs updating to reflect api sql API methods introduced in 0.13 #5936

Closed
ghost opened this issue Jan 14, 2014 · 13 comments
Closed

io.rst needs updating to reflect api sql API methods introduced in 0.13 #5936

ghost opened this issue Jan 14, 2014 · 13 comments
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Jan 14, 2014

@mangecoeur noted in #4163 (comment)

http://pandas.pydata.org/pandas-docs/stable/io.html#sql-queries
Also needs updating since it doesn't reflect the updated API 
(that was already introduced in 0.13 I think) which uses read_sql 
and to_sql for consistency with e.g. the CSV api.
@jreback
Copy link
Contributor

jreback commented Jan 23, 2014

cc @mangecoeur, @hayd

@mangecoeur
Copy link
Contributor

already done in the new SQL code ENH #4163, i rewrote quite a lot of the docs to take into account both new api and new capabilities.

@ghost
Copy link
Author

ghost commented Jan 23, 2014

#4163 is not a PR, do you mean #5950?

@jreback
Copy link
Contributor

jreback commented Jan 23, 2014

what was changed in 0.13.0 for sql?

@jreback
Copy link
Contributor

jreback commented Jan 24, 2014

@mangecoeur @y-p are we just pushing this (the doc updates) to 0.14? or doing anything minimal for 0.13.1?

@ghost
Copy link
Author

ghost commented Jan 24, 2014

I'll do it in time for 0.13.1

@ghost ghost self-assigned this Jan 24, 2014
@ghost
Copy link
Author

ghost commented Jan 25, 2014

d155623 was merged for 0.11.1 and introduced the pd.read_sql, pd.to_sql methods.
io.rst was not updated, and the examples continue to show how to import directly from
the io.sql namespace before use. the only method employed in the examples is read_frame.

pd.to_sql seemes to have not been available from the top level namespace in the last 3 releases,
since io/api.py was only updated to include read_sql. I haven't seen issues on that,
which makes me think it sees little use.

We probably shouldn't go back and expunge it in favor of #5950, but I'm uncertain how we should
handle this now, given that #5950 has discussion on top level naming and such.

I suggest we punt rather then paint ourselves into a corner at this point.

@ghost
Copy link
Author

ghost commented Jan 25, 2014

Bumped to 0.14

@ghost
Copy link
Author

ghost commented Feb 1, 2014

@hayd pushed a change directly to master f30499b, so now the example uses read_sql

@hayd
Copy link
Contributor

hayd commented Feb 2, 2014

Sorry @y-p, I had not seen this issue. Should I revert this?

Actually write_frame is also still mentioned (rather than to_sql ) :s.

@ghost
Copy link
Author

ghost commented Feb 2, 2014

It's fine, I just saw it and updated. I push to master directly too when I don't consider
it interesting enough for a PR, but it might be a bad habit.

The methods aren't going anywhere, it's just the toplevel namespace we'll
need to get sorted. Completing the doc update with to_sql would be good.

@jreback
Copy link
Contributor

jreback commented Feb 20, 2014

@jorisvandenbossche @mangecoeur close this? as I think you guys are already on top of docs and have several issues related

@jorisvandenbossche
Copy link
Member

Yes, this will be done as part of #6300.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants