Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Avoid two steps to access azure-pipelines logs #26895

Closed
datapythonista opened this issue Jun 16, 2019 · 4 comments
Closed

CI: Avoid two steps to access azure-pipelines logs #26895

datapythonista opened this issue Jun 16, 2019 · 4 comments
Labels
CI Continuous Integration Enhancement

Comments

@datapythonista
Copy link
Member

When we are in a PR, we got the list of all CI checks:
azure1

If we click in travis, it takes us to the travis log build, which seems reasonable. But when we click in one of the azure-pipelines builds, it takes us to this "Checks" tab, that how we have configured azire-pipelines, it provides literally no value, at least to me (never seen any useful information there):

azure2

Then what afaik we all do, is immediately click on the View more details on Azure Pipelines , so we go to azure-pipelines, and we can see the errors (if we have them highlighted, like for the linting), or we can click in the step and see the log:

azure3

I guess we have something configured incorrectly, because the second step (the "Checks" tab) doesn't add any value, it's just making things more complex for no reason.

@davidstaheli @vtbassmatt do you mind helping us here? What are we missing? It's not only us, checked numba and scikit-learn, and they've got the same as us. Thanks!

@davidstaheli
Copy link

Hi @datapythonista . Sorry for the inconvenience with this. Unfortunately, Azure Pipelines doesn't have much control over it. When a GitHub App (the recommended, new kind of app supported by GitHub) posts checks status to GitHub Checks, GitHub causes the link to point to the Checks tab which in turn links to the logs. The reason this doesn't happen with Travis and some others is because they're based on a GitHub OAuth App that doesn't use GitHub Checks. We're looking at ways to improve this for the Azure Pipelines GitHub App, like by putting the full logs in the Checks tab so that clicking the 2nd link isn't necessary.

@datapythonista
Copy link
Member Author

That makes sense, thanks a lot for the information @davidstaheli. Will report it to GitHub then.

@datapythonista
Copy link
Member Author

I've been told:

They can continue to create a commit status instead of creating a check with GitHub Apps

Not sure if that makes sense, not an expert on the GitHub API myself.

@datapythonista
Copy link
Member Author

We're not using azure pipelines anymore, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants