-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RLS: 0.25.0 #24950
Comments
@pandas-dev/pandas-core as we briefly discussed before, we need to be pretty circumspect about merging even to master changes that are not backportable to 0.24.x, prob for a little while. Small changes ok, but sweeping reorgs just make backporting much more difficult (as may need to go thru potentially a lot of effort to backport). So am going to suggest that we hold off on 'bigger' things until 0.24.1 is out.
|
Do we have any major goals for 0.25.0? |
|
I think one of the key points is still to decide on a policy for dealing with breaking changes, both for 0.25/1.0 and after. There's still a bunch of inconsistencies that we'd be locking in for 1.0, and even more so if we'd be doing actual SemVer afterwards - changing a
This list is obviously not exhaustive. Pandas is certainly very mature by now, but IMO not consistent enough to do SemVer (otherwise every release would be major). Maybe numpy-style rolling deprecations (as we've been doing as well) would be less restrictive to actually fixing some of these issues (it's worth noting that on the numpy side, it will still take monumental determination and effort to actually fix some very longstanding issues for an eventual 2.0) There's much smaller fish I'd like to fry as well, but all of which are breaking in some way.
TL;DR: most bigger PRs are breaking from the point of SemVer. A policy of zero breaking changes until 1.0 will probably mean little development. |
What is the likely pandas-0.25.0 release date ? |
@stonebig we didn't really discuss in detail recently, but I think we still target to release somewhere in June (but no guarantees!) |
Are we on track for cutting an RC today? (my gut says "not quite"). I'm fixing up a few CI issues across pandas & dask right now. Will do a run through outstanding issues after that (I know I have the |
yeah let’s get ci fixed and merge what we can |
@jorisvandenbossche @TomAugspurger I am super busy today / tomorrow, so don't block on me for things and merge where you guys think appropriate. if you want me to specifically review something, pls ping. |
@pandas-dev/pandas-core I think #27095 is the last one for the RC. I'll try to tag 0.25.0rc0 tonight (~5 hours from now). LMK if there are any others that should go in. |
If we do #26043, I think should include that in the RC as well (but seems green apart from some code check) |
I just pushed a patch for #26043 - hopefullly should be green soon. |
If #25427 is mergeable would be good to get in before release |
I just opened #27221; I've marked it as 0.25.0 but I'm not dead set on getting it into 0.25.0. No need to hold up the RC for it. I have a couple other small |
Is it too late to remove _IXIndexer before for 0.25.0? I'm finding some ugly code in internals is only reached via |
Feels a bit late. I'd like to tag the RC soon (next hour if possible). |
We only changed the warning to FutureWarning this release, so it in any case only to remove for 1.0 I think. @jschendel for the interval ones, if they are new features that don't really touch existing behaviours, we can maybe merge some after the RC |
OK, black went in, so all ready to tag I think (I am offline now) |
@pandas-dev/pandas-core tagged 0.25.0rc0. Binary packages are building at conda-forge/pandas-feedstock#64 and MacPython/pandas-wheels#54. Building the docs. Will push them tomorrow morning and send out the announcement. |
There is a lot of activity (which is great), but since we put a RC out, I think we should be a bit careful with merging a lot of refactoring / cleaning PRs (they always have a small risk of breaking something that was not covered) or further PRs removing things (I just commented on #27377). Instead of holding up some PRs, we could also already branch 0.25.x and specifically pick PRs to backport? (with the bot that goes rather smooth). |
Any idea about the timeframe for 0.25? statsmodels needs a point release I think for 0.25 and so it would be good to have it ready to go when pandas releases. |
@bashtage will let you know later today. @jreback @jorisvandenbossche I'm back online today, getting caught up. I recall seeing a message about an API breaking change being merged in the RC, so we'll need to revert that or have a second RC? I'll post when I find what I'm talking about. |
nothing significant has been merged, so I think the release is pretty good (ex my comments above). |
Maybe want to revert #27252 - I can try to get to that in next day or so but if someone else wants to tackle in the meantime wouldn't mind |
@TomAugspurger ok just a couple issues that are on for 0.25 (the viz things), other than that lgtm. |
As of now there are two plotting issues still tagged for 0.25 #27152 and #26747 - are these still valid? I don't see any open PRs referencing them so OK to remove from the milestone? There's one open PR #27384 but looks to be near completion; any objection to calling it a release after that gets merged? |
I think the plotting issues are OK to push (and #27152 can maybe be closed. Need to check). |
Released! |
thanks for the release @WillAyd ! |
Tracking issue for 0.25.0
The text was updated successfully, but these errors were encountered: