-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Enable spellcheck in docbuild #21354
Comments
Is this issue still open? @TomAugspurger |
I would like to take on this since this is related to my previous PR 😄 |
@daminisatya Apologies I had this tab open and your comment didnt show but you beat me to it so if you would like to take on this issue go ahead 😄 👍 |
@daminisatya since you marked interest in this and the JSON issue how about you tackle the JSON one as a first contribution and let @FabioRosado continue with this one, since this is a logical follow up to a change he just made? |
Yes @WillAyd, I was about to comment the same :) @FabioRosado you can go ahead with the issue since you have already solved it you will have a better context than me! I took up another first-timer issue. |
Update: Appears this was added and then subsequently removed. In #24287, the comment that:
doesn't seem to be true anymore. I'm seeing releases for both enchant and pyenchant in December 2020. In other words, I think we should consider adding spellcheck back in. |
Currently we run pandas/.pre-commit-config.yaml Lines 202 to 205 in 00ddacf
We could expand it to the docs and see how it compares…? |
Seems like the issues are duplicates, so closing this one for now. |
Followup to #21109
We'll need to refactor
scripts/announce.py
to update the list of contributors on each build.Then we can enable spellcheck in the Travis doc build.
The text was updated successfully, but these errors were encountered: