Unified common dtype discovery #13947
Labels
Compat
pandas objects compatability with Numpy or Python functions
Dtype Conversions
Unexpected or buggy dtype conversions
Milestone
Common dtype discovery (like
np.find_common_type
) should be unified into an internal function, with proper handling ofpandas
dtypes. As of #13917, there are two such implementations:pandas/types/common.py:_lcd_dtypes
, which works onnumpy
dtypes only, but differently thannp.find_common_type
.pandas/types/cast.py:_find_common_type
, which just usesnp.find_common_type
internally.Exchanging the first one with the second (which is, judging by the code, more proper), breaks some tests.
Proposed tasks:
_lcd_dtypes
into_find_common_types
._find_common_types
to properly evaluatepandas
dtypes.Occurences of
_lcd_dtypes
, the one ininternals.py
is removed by #13917:The text was updated successfully, but these errors were encountered: