Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: skipfooter or skip_footer? read_csv can't seem to decide #13349

Closed
gfyoung opened this issue Jun 2, 2016 · 3 comments
Closed

API: skipfooter or skip_footer? read_csv can't seem to decide #13349

gfyoung opened this issue Jun 2, 2016 · 3 comments
Labels
API Design IO CSV read_csv, to_csv
Milestone

Comments

@gfyoung
Copy link
Member

gfyoung commented Jun 2, 2016

skipfooter : "This line here says I am the right choice."

skip_footer : "This line here says I am the right choice."

Whatever the case is, something should certainly be done to avoid having duplicate arguments for the same thing, as can be seen here

@jreback
Copy link
Contributor

jreback commented Jun 2, 2016

The full-list is here: #4988

Yeah should prob fix this. I think the _ are better (though I wouldn't change for example usecols)
and skiprows is in-line with skipfooter.

We should see what changes to make this reasonable and minimze the deprecations (including maybe doing nothing).

@jreback jreback added API Design IO CSV read_csv, to_csv labels Jun 2, 2016
@gfyoung
Copy link
Member Author

gfyoung commented Jun 2, 2016

Yeah, not sure what is best yet. Just wanted to mention this problem since having duplicate arguments in the API isn't a good thing. A more careful analysis of the API / code would be needed to make sure that we don't change too much unnecessarily.

@gfyoung
Copy link
Member Author

gfyoung commented Jun 7, 2016

After another looking, I'm inclined to deprecate skipfooter because the _ is used internally throughout the code. I'll take a look at that first and change any relevant tests as well to use the "correct" one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design IO CSV read_csv, to_csv
Projects
None yet
Development

No branches or pull requests

2 participants