-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvement: Change to_excel "sheet_name" to "sheetname" #10559
Comments
Agree we should make them the same (at least make it available, maybe not necessary to actually deprecate the discouraged alias). I am only not fully sure if would go with And @saintsfan342000, opening an issue for this is very good! If you get approval, always welcome to open a PR afterwards! |
current (0.20.x) branch appears to mostly use
49 occurrences of sheet_name in io
25 occurrences of sheetname in io
|
pd.read_excel() takes "sheetname" as an argument.
pd.DataFrame.to_excel() takes "sheet_name" as an argument.
For consistency, I think one ought to be changed to match the other.
On my windows installation of pandas 0.16.2, I modified to_excel to take sheetname rather than sheet_name. All I had to do was locate frame.py within the core directory. to_excel() is defined here, and sheet_name is written twice in the function and once in the docstring.
Very new to github so if ideas like these are more appropriately filed through PRs I apologize.
The text was updated successfully, but these errors were encountered: