Sort fileFailures by line and character?

[eggggger]

😳

[ajafff]

Is this a feature request for the API or the CLI?
Can you please be elaborate a bit more about your use case?

[eggggger]

If i delete a line for fix some errors like no-unused-variable, the next line number in error messages will go wrong, so I always fix errors by bottom-up. But now the line number is unordered.

[eggggger]

@ajafff For example

and

fileFailures = fileFailures.sort((failureA, failureB): number => {
    const failureALineAndCharacter = failureA.getStartPosition().getLineAndCharacter()
    const failureBLineAndCharacter = failureB.getStartPosition().getLineAndCharacter()
    if (failureALineAndCharacter.line === failureBLineAndCharacter.line) {
        return failureALineAndCharacter.character - failureBLineAndCharacter.character
    }
    return failureALineAndCharacter.line - failureBLineAndCharacter.line
})

[ajafff]

@eggggger I see, so we are only talking about the formatted output when running TSLint CLI.

That means we don't need to sort the failures unconditionally. It's only required for formatters intended for human consumers.

[ajafff]

Fixed by #3345