Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Code style question: split a rule's source across files? #2399

Closed
JoshuaKGoldberg opened this issue Mar 24, 2017 · 2 comments
Closed

Code style question: split a rule's source across files? #2399

JoshuaKGoldberg opened this issue Mar 24, 2017 · 2 comments

Comments

@JoshuaKGoldberg
Copy link
Contributor

Context: I'm refactoring the completed-docs rule and getting annoyed at everything being in the same file. Would it be horribly offensive to anyone if I made a src\rules\completed-docs subdir to hold the utility classes?
@adidahiya
Copy link
Contributor

sounds fine to me. how many LOC are we talking about?

@JoshuaKGoldberg
Copy link
Contributor Author

Thankfully not too many. Excluding 17 LOC in each file for the header:

  • src/rules/completedDocsRule: 201
  • src/rules/completed-docs/blockRequirement.ts: 25
  • src/rules/completed-docs/classRequirement.ts: 47
  • src/rules/completed-docs/requirement.ts: 18
  • src/rules/completed-docs/requirementDescriptors.ts: 10
  • src/rules/completed-docs/requirementFactory.ts: 33

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adidahiya @JoshuaKGoldberg