Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

typedef-whitespace onespace doesn't accept newlines #1521

Closed
spiffytech opened this issue Aug 26, 2016 · 4 comments
Closed

typedef-whitespace onespace doesn't accept newlines #1521

spiffytech opened this issue Aug 26, 2016 · 4 comments

Comments

@spiffytech
Copy link

Bug Report

  • TSLint version: 3.15.1
  • TypeScript version: 2.1.0-dev.20160731
  • Running TSLint via: CLI / vim syntastic

TypeScript code being linted

/**
 * Problem comes up when function signature exceeds line length limit
 * and I have to break it onto multiple lines
 */
function example(
  {a, b}:
  {a: number, b: number}
) {
  return "Hello, World!";
}

with tslint.json configuration:

"extends": "tslint:recommended"

Actual behavior

test.ts[2, 10]: expected onespace after colon in parameter

Expected behavior

tslint should accept a newline as a valid separator for type definitions

@adidahiya
Copy link
Contributor

fixed by #1531

@spiffytech
Copy link
Author

Can you please publish a bugfix release that includes this fix?

@adidahiya
Copy link
Contributor

4.0.0-dev.0 and 4.0.0-dev.1 include the fix, does that work for you? or do you need a 3.15 patch

@spiffytech
Copy link
Author

How many more breaking changes are expected before 4.0 final? If most breaking changes are already implemented, I could upgrade to dev.1. But if more are coming, I'd prefer a 3.15 patch so I can get this fix now, and then do all of my 4.0 changes later, in a single batch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants