Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Require.resolve() in extends cause config not loaded when changed (in vscode) #1128

Closed
unional opened this issue Apr 14, 2016 · 0 comments
Closed

Comments

@unional
Copy link
Contributor

unional commented Apr 14, 2016

Referencing:
https://github.com/Microsoft/vscode-tslint/issues/45

This is caused by https://github.com/palantir/tslint/blob/master/src/configuration.ts#L139 using require(...) to load the file. require() would cache the file, preventing any change to file to be reloaded.

The proposed change is to load the file directly as before. Since now the path is properly resolve (including using require.resolve()) in resolveConfigurationPath(configFilePath);, we are safe to do that.

cc @egamma

I can create a PR on that tomorrow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant