distTar does not pick up the correct serviceName

[cihati]

After upgrading to sls-packaging 2.x, our publish task started to fail for Postgate.

As an example, when we run ./gradlew distTar an artifact named /Users/cihati/dev/postgate/postgate-distribution/build/distributions/postgate-0.6.0-2-gc2b4bf9.dirty.sls.tgz is created. However, when running ./gradlew postgate-distribution:publish, we get an error:

:postgate-distribution:publishArtifactoryPublicationToInternal-distRepository FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':postgate-distribution:publishArtifactoryPublicationToInternal-distRepository'.
> Failed to publish publication 'artifactory' to repository 'internal-dist'
   > Invalid publication 'artifactory': artifact file does not exist: '/Users/cihati/dev/postgate/postgate-distribution/build/distributions/postgate-distribution-0.6.0-2-gc2b4bf9.dirty.sls.tgz'

Please note that we define serviceName as postgate inside postgate-distribution/build.gradle -- however this isn't being picked up. As a workaround, we explicitly set tasks.distTar.baseName = 'postgate', but this needs to be fixed inside sls-packaging. Per @uschi2000 the problem is that distTar gets the serviceName after evaluation phase (

sls-packaging/gradle-sls-packaging/src/main/groovy/com/palantir/gradle/dist/service/JavaServiceDistributionPlugin.groovy

Line 92 in 1bf73a8

project.afterEvaluate {

), but publish task gets it before ( https://github.palantir.build/foundry/postgate/blob/develop/postgate-distribution/build.gradle#L41 )