From e5a512657515faa8dcf0be8b9cadc84680cd7ad5 Mon Sep 17 00:00:00 2001 From: Matthew Kurnia Date: Wed, 18 Dec 2024 11:30:51 +0000 Subject: [PATCH 1/5] feat: new icon - subtract join --- packages/icons/icons.json | 7 +++++++ resources/icons/16px/subtract-join.svg | 4 ++++ resources/icons/20px/subtract-join.svg | 4 ++++ 3 files changed, 15 insertions(+) create mode 100644 resources/icons/16px/subtract-join.svg create mode 100644 resources/icons/20px/subtract-join.svg diff --git a/packages/icons/icons.json b/packages/icons/icons.json index 87679c6cb1..fdad1e38b2 100644 --- a/packages/icons/icons.json +++ b/packages/icons/icons.json @@ -3030,6 +3030,13 @@ "group": "action", "codepoint": 62101 }, + { + "displayName": "Join: subtract", + "iconName": "subtract-join", + "tags": "circles, combine, connect, add, subtract, part, slice, intersection, venn diagram, intersect", + "group": "action", + "codepoint": 62354 + }, { "displayName": "Strikethrough", "iconName": "strikethrough", diff --git a/resources/icons/16px/subtract-join.svg b/resources/icons/16px/subtract-join.svg new file mode 100644 index 0000000000..f38289ef97 --- /dev/null +++ b/resources/icons/16px/subtract-join.svg @@ -0,0 +1,4 @@ + + + + diff --git a/resources/icons/20px/subtract-join.svg b/resources/icons/20px/subtract-join.svg new file mode 100644 index 0000000000..eedd5fc95b --- /dev/null +++ b/resources/icons/20px/subtract-join.svg @@ -0,0 +1,4 @@ + + + + From 2ed3be91095c6c56c2def816260c649bc9ab3326 Mon Sep 17 00:00:00 2001 From: Matthew Kurnia Date: Mon, 6 Jan 2025 10:44:21 +0000 Subject: [PATCH 2/5] pr feedback --- packages/icons/icons.json | 14 +++++++------- resources/icons/16px/subtract-join.svg | 6 +++--- resources/icons/20px/subtract-join.svg | 6 +++--- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/icons/icons.json b/packages/icons/icons.json index fdad1e38b2..9c1e0402ec 100644 --- a/packages/icons/icons.json +++ b/packages/icons/icons.json @@ -3030,13 +3030,6 @@ "group": "action", "codepoint": 62101 }, - { - "displayName": "Join: subtract", - "iconName": "subtract-join", - "tags": "circles, combine, connect, add, subtract, part, slice, intersection, venn diagram, intersect", - "group": "action", - "codepoint": 62354 - }, { "displayName": "Strikethrough", "iconName": "strikethrough", @@ -4604,5 +4597,12 @@ "tags": "data, source, data source, sync, cloud", "group": "data", "codepoint": 62353 + }, + { + "displayName": "Join: subtract right", + "iconName": "subtract-right-join", + "tags": "circles, combine, connect, add, subtract, part, slice, intersection, venn diagram, intersect", + "group": "action", + "codepoint": 62354 } ] diff --git a/resources/icons/16px/subtract-join.svg b/resources/icons/16px/subtract-join.svg index f38289ef97..3e31371a5f 100644 --- a/resources/icons/16px/subtract-join.svg +++ b/resources/icons/16px/subtract-join.svg @@ -1,4 +1,4 @@ - - - + + + diff --git a/resources/icons/20px/subtract-join.svg b/resources/icons/20px/subtract-join.svg index eedd5fc95b..2ff82ed167 100644 --- a/resources/icons/20px/subtract-join.svg +++ b/resources/icons/20px/subtract-join.svg @@ -1,4 +1,4 @@ - - - + + + From 80c19fac2b299572a245af09017a8c3127d426ce Mon Sep 17 00:00:00 2001 From: Matthew Kurnia Date: Mon, 6 Jan 2025 10:56:48 +0000 Subject: [PATCH 3/5] rename icons --- .../icons/16px/{subtract-join.svg => subtract-right-join.svg} | 0 .../icons/20px/{subtract-join.svg => subtract-right-join.svg} | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename resources/icons/16px/{subtract-join.svg => subtract-right-join.svg} (100%) rename resources/icons/20px/{subtract-join.svg => subtract-right-join.svg} (100%) diff --git a/resources/icons/16px/subtract-join.svg b/resources/icons/16px/subtract-right-join.svg similarity index 100% rename from resources/icons/16px/subtract-join.svg rename to resources/icons/16px/subtract-right-join.svg diff --git a/resources/icons/20px/subtract-join.svg b/resources/icons/20px/subtract-right-join.svg similarity index 100% rename from resources/icons/20px/subtract-join.svg rename to resources/icons/20px/subtract-right-join.svg From 5e841b0af0c9159c895ff860ed4318e96d2eedb4 Mon Sep 17 00:00:00 2001 From: Matthew Kurnia Date: Tue, 7 Jan 2025 16:37:12 +0000 Subject: [PATCH 4/5] make into single paths --- resources/icons/16px/subtract-right-join.svg | 5 ++--- resources/icons/20px/subtract-right-join.svg | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/resources/icons/16px/subtract-right-join.svg b/resources/icons/16px/subtract-right-join.svg index 3e31371a5f..057d74a95a 100644 --- a/resources/icons/16px/subtract-right-join.svg +++ b/resources/icons/16px/subtract-right-join.svg @@ -1,4 +1,3 @@ - - - + + diff --git a/resources/icons/20px/subtract-right-join.svg b/resources/icons/20px/subtract-right-join.svg index 2ff82ed167..79d8ffb5c9 100644 --- a/resources/icons/20px/subtract-right-join.svg +++ b/resources/icons/20px/subtract-right-join.svg @@ -1,4 +1,4 @@ - - + + From 18c3b24118441d63a8d19a1c952e103deb4be65d Mon Sep 17 00:00:00 2001 From: svc-changelog Date: Wed, 8 Jan 2025 10:53:59 +0000 Subject: [PATCH 5/5] Add generated changelog entries --- packages/icons/changelog/@unreleased/pr-7132.v2.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 packages/icons/changelog/@unreleased/pr-7132.v2.yml diff --git a/packages/icons/changelog/@unreleased/pr-7132.v2.yml b/packages/icons/changelog/@unreleased/pr-7132.v2.yml new file mode 100644 index 0000000000..b45a292eb5 --- /dev/null +++ b/packages/icons/changelog/@unreleased/pr-7132.v2.yml @@ -0,0 +1,5 @@ +type: feature +feature: + description: 'feat: new icon - subtract join' + links: + - https://github.com/palantir/blueprint/pull/7132