Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateRangePicker] Shortcuts do not take into account minDate and maxDate #608

Closed
leebyp opened this issue Feb 2, 2017 · 0 comments
Closed

[DateRangePicker] Shortcuts do not take into account minDate and maxDate #608

leebyp opened this issue Feb 2, 2017 · 0 comments
Assignees
@cmslewis
Labels
P2 Package: datetime Type: bug
Milestone
1.23.0

Comments

@leebyp
Copy link
Contributor

leebyp commented Feb 2, 2017

Bug report

  • Package version(s): 1.7

Steps to reproduce

const minDate = new Date(2016, 10, 1);
const maxDate = new Date(2016, 11, 29);
<DateRangePicker
    minDate={minDate}
    maxDate={maxDate}
/>

Actual behavior

screen shot 2017-02-02 at 14 58 46

Expected behavior

Disable shortcut if not in the allowed range
@adidahiya adidahiya added the P2 label Feb 2, 2017
@cmslewis cmslewis mentioned this issue Jul 1, 2017
Merged
2 tasks
@cmslewis cmslewis changed the title DateRangePicker defaultShortcuts do not take into account minDate and maxDate [DateRangePicker] defaultShortcuts do not take into account minDate and maxDate Jul 1, 2017
@cmslewis cmslewis changed the title [DateRangePicker] defaultShortcuts do not take into account minDate and maxDate [DateRangePicker] Shortcuts do not take into account minDate and maxDate Jul 1, 2017
@cmslewis cmslewis added this to the 1.22.0 milestone Jul 1, 2017
@cmslewis cmslewis self-assigned this Jul 1, 2017
@llorca llorca modified the milestones: 1.22.0, 1.23.0 Jul 5, 2017
@snyk-bot snyk-bot mentioned this issue Apr 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmslewis cmslewis

Labels
P2 Package: datetime Type: bug
Projects
None yet
Milestone
1.23.0
Development

No branches or pull requests
4 participants
@llorca @cmslewis @adidahiya @leebyp