You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems like throughout your codebase you use double equals to check for null/undefined values (value == null) so you wouldn't run into this issue.
But on stricter codebases which want to be more explicit, if we follow the types we would only check for === undefined when the value could also potentially be null.
The text was updated successfully, but these errors were encountered:
This is true across virtually all of blueprint's type definitions because we don't use the strictNullChecks compiler option. Everything is potentially null. We'd like to enable this option, but it's a large change to make across the codebase. We'll get to it someday...
The
DateRangeInput
can call itsonChange
handler willnull
values in the range (as mentioned in the following comment):blueprint/packages/datetime/src/dateRangeInput.tsx
Lines 95 to 104 in 44043fd
But the
DateRange
type doesn't includenull
in its signature:blueprint/packages/datetime/src/common/dateUtils.ts
Line 19 in 44043fd
It seems like throughout your codebase you use double equals to check for
null
/undefined
values (value == null
) so you wouldn't run into this issue.But on stricter codebases which want to be more explicit, if we follow the types we would only check for
=== undefined
when the value could also potentially benull
.The text was updated successfully, but these errors were encountered: