NumericInput requires min to be strictly less than max if both are defined

[n1313]

Environment

@blueprintjs/core: 3.10.0
Firefox 64.0.2, MacOS

Context

I have a Pagination component that uses NumericInput to display the current page number. My intention is to let users manually input their target page number to navigate directly to it, without having to click "next page" button many times. I am using min and max props to prevent users from entering wrong page numbers using "increment/decrement" buttons. Sometimes, I only have one page to display, which means that the only valid value for the input is "1". This makes NumericInput throw an error.

Steps to reproduce

<NumericInput min={1} max={1} />

Actual behavior

Component throws an error "Error: [Blueprint] requires min to be strictly less than max if both are defined." and is not rendered.

Expected behavior

Component is rendered and allows min and max values to be equal.

Possible solutions

1. Remove the restriction from NumericInput by allowing min to be equal to max.
2. Document the restriction and provide recommended workaround for cases like mine.

[giladgray]

@n1313 ah interesting. sure, it seems reasonable to change the condition to <= to allow min === max. interested in submitting a PR?

[giladgray]

nevermind, i'm about to open a PR for this.

[n1313]

Hi @giladgray, yes, I would like to contribute but I seem to be late to the party. Thank you for taking this issue!

[n1313]

@giladgray when is this fix scheduled to be released? Thanks!

[giladgray]

@n1313 tomorrow I believe